Fixed the error message, which was causing an error.

[profiler-torch.git] / profiler.lua

diff --git a/profiler.lua b/profiler.lua
old mode 100755 (executable)
new mode 100644 (file)
index 6f63861..4420af7
--- a/profiler.lua
+++ b/profiler.lua
@@ -37,7 +37,17 @@ require 'sys'
 
 profiler = {}
 
-function profiler.decor(model, functionsToDecorate)
+profiler.color = true
+
+profiler.colors = function(name)
+   if profiler.color then
+      return sys.COLORS[name]
+   else
+      return ''
+   end
+end
+
+function profiler.decorate(model, functionsToDecorate)
 
    local functionsToDecorate = functionsToDecorate or
       {
@@ -48,22 +58,23 @@ function profiler.decor(model, functionsToDecorate)
    for _, name in pairs(functionsToDecorate) do
       model.accTime = {}
 
-      local functionTable = model
+      local nameOrig = name .. '__orig'
 
-      -- We decorate the function where it is defined in the class
-      -- hierarchy, so we have to go up the metatables until we find
-      -- it with rawget
+      -- We decorate the class and not the object, otherwise we cannot
+      -- save models anymore.
 
-      while functionTable and not rawget(functionTable, name) do
-         functionTable = getmetatable(functionTable)
+      if rawget(model, name) then
+         error('We decorate the class, not the objects, and there is a `'
+                  .. name
+                  .. '\' function in '
+                  .. tostring(model))
       end
 
-      local nameOrig = name .. '__orig'
+      local toDecorate = getmetatable(model)
 
-      if functionTable[name] and not functionTable[nameOrig] then
-         print('Profiler decoring ' .. functionTable.__typename .. '.' .. name)
-         functionTable[nameOrig] = functionTable[name]
-         functionTable[name] = function(self, ...)
+      if toDecorate[name] and not toDecorate[nameOrig] then
+         toDecorate[nameOrig] = toDecorate[name]
+         toDecorate[name] = function(self, ...)
             local startTime = sys.clock()
             local result = { self[nameOrig](self, unpack({...})) }
             local endTime = sys.clock()
@@ -76,37 +87,55 @@ function profiler.decor(model, functionsToDecorate)
 
    if torch.isTypeOf(model, nn.Container) then
       for _, m in ipairs(model.modules) do
-         profiler.decor(m, functionsToDecorate)
+         profiler.decorate(m, functionsToDecorate)
       end
    end
 
 end
 
-function profiler.print(model, nbSamples, indent)
+function profiler.timing(l, t, nbSamples, totalTime)
+   local s = string.format('%s %.02fs', l, t)
+   if totalTime then
+      s = s .. string.format(profiler.colors('blue') .. ' [%.02f%%]', 100 * t / totalTime)
+   end
+   if nbSamples then
+      s = s .. string.format(profiler.colors('green') .. ' (%.01fmus/sample)', 1e6 * t / nbSamples)
+   end
+   s = s .. profiler.colors('black')
+   return s
+end
+
+function profiler.print(model, nbSamples, totalTime, indent)
    local indent = indent or ''
+   local hint
 
-   print(string.format('%s* %s', indent, model.__typename))
+   local localTotal = 0
+   for _, t in pairs(model.accTime) do
+      localTotal = localTotal + t
+   end
 
-   if nbSamples then
-      for l, t in pairs(model.accTime) do
-         print(string.format('%s  %s %.02fs (%.01fmus/sample)',
-                             indent,
-                             l,
-                             t,
-                             1e6 * t / nbSamples))
-      end
+   if torch.isTypeOf(model, nn.Container) then
+      hint = ' '
    else
-      for l, t in pairs(model.accTime) do
-         print(string.format('%s  %s %.02fs',
-                             indent,
-                             l,
-                             t))
+      if profiler.color then
+         hint = ' '
+      else
+         hint = '*'
       end
+      hint = hint .. profiler.colors('red')
    end
 
+   print(profiler.timing(indent .. hint .. ' ' .. model.__typename, localTotal, nbSamples, totalTime))
+
+   for l, t in pairs(model.accTime) do
+      print(profiler.timing(indent .. '  ' .. l, t, nbSamples, totalTime))
+   end
+
+   print()
+
    if torch.isTypeOf(model, nn.Container) then
       for _, m in ipairs(model.modules) do
-         profiler.print(m, nbSamples, indent .. '  ')
+         profiler.print(m, nbSamples, totalTime, indent .. '  ')
       end
    end
 end