X-Git-Url: https://fleuret.org/cgi-bin/gitweb/gitweb.cgi?p=agtree2dot.git;a=blobdiff_plain;f=README.md;h=452aa9cba717f36e8a1c9a11c0a09918bff12f2f;hp=6b996b4d89c02af54af942f73671e7a88eb7a5d8;hb=d9e6125c82f4e3775b8c868751b1657a6a147f55;hpb=55332826c1d0ec125fc1d2db6644c98b1640d4a2

diff --git a/README.md b/README.md
index 6b996b4..452aa9c 100644
--- a/README.md
+++ b/README.md
@@ -10,14 +10,17 @@ from a [pytorch](http://pytorch.org) autograd graph.
 
 ### agtree2dot.save_dot(variable, variable_labels, result_file) ###
 
-Saves into `result_file` a dot file corresponding to the autograd graph for `variable`, which can be either a single `Variable` or a set of `Variable`s. The dictionary `variable_labels` associates strings to some variables, which will be used in the resulting graph.
+Saves into `result_file` a dot file corresponding to the autograd
+graph for the `Variable` `variable`. The dictionary `variable_labels`
+associates strings to some variables, which will be used in the
+resulting graph.
 
 ## Example ##
 
-A typical use would be:
+A typical use is provided in [mlp.py](https://fleuret.org/git-extract/agtree2dot/mlp.py):
 
 ```python
-import torch
+import subprocess
 
 from torch import nn
 from torch.nn import functional as fn
@@ -47,15 +50,28 @@ criterion = nn.MSELoss()
 loss = criterion(output, target)
 
 agtree2dot.save_dot(loss,
-                    { input: 'input', target: 'target', loss: 'loss' },
+                    {
+                        input: 'input',
+                        target: 'target',
+                        loss: 'loss',
+                        mlp.fc1.weight: 'weight1',
+                        mlp.fc1.bias: 'bias1',
+                        mlp.fc2.weight: 'weight2',
+                        mlp.fc2.bias: 'bias2',
+                    },
                     open('./mlp.dot', 'w'))
-```
 
-which would generate a file mlp.dot, which can then be translated to
-pdf using the [Graphviz tools](http://www.graphviz.org/)
+print('Generated mlp.dot')
 
-```
-dot mlp.dot -Lg -T pdf -o mlp.pdf
+try:
+    subprocess.check_call(["dot", "mlp.dot", "-Lg", "-T", "pdf", "-o", "mlp.pdf" ])
+except subprocess.CalledProcessError:
+    print('Calling the dot command failed. Is Graphviz installed?')
+    sys.exit(1)
+
+print('Generated mlp.pdf')
 ```
 
-to produce [mlp.pdf.](https://fleuret.org/git-extract/agtree2dot/mlp.pdf)
+which would generate a file mlp.dot and try to generate
+[mlp.pdf](https://fleuret.org/git-extract/agtree2dot/mlp.pdf) from it
+with [Graphviz tools.](http://www.graphviz.org/)