X-Git-Url: https://fleuret.org/cgi-bin/gitweb/gitweb.cgi?a=blobdiff_plain;f=selector.c;h=7f64ebad916ffd831a5c8c590072250459953cb3;hb=a01943060785bb070dc793818dcd2219c68a5672;hp=ed30692c7b33b7ca3bef64e179f0f227c87be9c0;hpb=cd2588f04d4d909d5108ba705fcba0337d89ac9c;p=selector.git

diff --git a/selector.c b/selector.c
index ed30692..7f64eba 100644
--- a/selector.c
+++ b/selector.c
@@ -76,8 +76,9 @@ int attr_modeline, attr_focus_line, attr_error;
 
 void *safe_malloc(size_t n) {
   void *p = malloc(n);
-  if (!p && n != 0) {
-    printf("Can not allocate memory: %s\n", strerror(errno));
+  if(!p && n != 0) {
+    fprintf(stderr,
+            "selector: can not allocate memory: %s\n", strerror(errno));
     exit(EXIT_FAILURE);
   }
   return p;
@@ -290,7 +291,8 @@ int add_and_get_previous_index(struct hash_table_t *hash_table,
     /* We came back to our original code, which means that the table
        is full */
     if(code == start) {
-      printf("Full hash table (that should not happen)\n");
+      fprintf(stderr,
+              "Full hash table (that should not happen)\n");
       exit(EXIT_FAILURE);
    }
   }
@@ -781,7 +783,7 @@ void read_file(struct hash_table_t *hash_table,
                int nb_lines_max, int *nb_lines, char **lines) {
 
   char raw_line[BUFFER_SIZE];
-  int start, end, eol, k;
+  char *s;
   FILE *file;
 
   file = fopen(input_filename, "r");
@@ -791,51 +793,11 @@ void read_file(struct hash_table_t *hash_table,
     exit(EXIT_FAILURE);
   }
 
-  start = 0;
-  end = 0;
-
-  while(*nb_lines < nb_lines_max && (end > start || !feof(file))) {
-    eol = start;
-
-    /* Look for the end of a line in what is already in the buffer */
-    while(eol < end && raw_line[eol] != '\n') eol++;
-
-    /* if we did not find the of a line, move what has not been
-       processed and is in the buffer to the beginning of the buffer,
-       fill the buffer with new data from the file, and look for the
-       end of a line */
-    if(eol == end) {
-      for(k = 0; k < end - start; k++) {
-        raw_line[k] = raw_line[k + start];
-      }
-      end -= start;
-      eol -= start;
-      start = 0;
-      end += fread(raw_line + end, sizeof(char), BUFFER_SIZE - end, file);
-      while(eol < end && raw_line[eol] != '\n') eol++;
-    }
-
-    /* The end of the line is the buffer size, which means the line is
-       too long */
-
-    if(eol == BUFFER_SIZE) {
-      raw_line[BUFFER_SIZE - 1] = '\0';
-      fprintf(stderr, "selector: Line too long (max is %d characters):\n",
-              BUFFER_SIZE);
-      fprintf(stderr, "%s", raw_line);
-      fprintf(stderr, "\n");
-      exit(EXIT_FAILURE);
+  while(*nb_lines < nb_lines_max && fgets(raw_line, BUFFER_SIZE, file)) {
+    for(s = raw_line + strlen(raw_line) - 1; s > raw_line && *s == '\n'; s--) {
+      *s = '\0';
     }
-
-    /* If we got a line, we replace the carriage return by a \0 to
-       finish the string */
-
-    raw_line[eol] = '\0';
-
-    store_line(hash_table, raw_line + start,
-               nb_lines, lines);
-
-    start = eol + 1;
+    store_line(hash_table, raw_line, nb_lines, lines);
   }
 
   fclose(file);
@@ -1261,7 +1223,7 @@ int main(int argc, char **argv) {
 
   /* Here we come back to standard display */
 
-  if((key == KEY_ENTER || key == '\n')) {
+  if(key == KEY_ENTER || key == '\n') {
 
     char *t;