X-Git-Url: https://fleuret.org/cgi-bin/gitweb/gitweb.cgi?a=blobdiff_plain;f=mygpt.py;h=7c4e06df1259aa4bd372987589ababf5f5afd6b1;hb=6260a3593ac09a9bbdd9c85b23d78a71fa028acd;hp=4951460655929a986949af77471b97911bf77592;hpb=d62602e1d7f3ae1c7c2e0ab6f6751ebbc3b06047;p=mygpt.git

diff --git a/mygpt.py b/mygpt.py
index 4951460..7c4e06d 100755
--- a/mygpt.py
+++ b/mygpt.py
@@ -36,37 +36,51 @@ class PositionalEncoding(nn.Module):
         t = torch.arange(x.size(1), dtype = x.dtype, device = x.device)[:, None]
         j = torch.arange(x.size(2), dtype = x.dtype, device = x.device)[None, :]
         k = j%2
-        return x + torch.sin(t / (self.len_max ** ((j - k) / x.size(2))) + math.pi/2 * k)[None, :, :]
+        pe = torch.sin(t / (self.len_max ** ((j - k) / x.size(2))) + math.pi/2 * k)
+        return x + pe # Let broadcasting to its job
 
 ##############################
 
 class QKVAttention(nn.Module):
-    def __init__(self, dim_in, dim_qk, dim_v,
-                 nb_heads = 1, causal = False, attention_dropout = 0.0):
+    def __init__(
+            self,
+            dim_in, dim_qk, dim_v,
+            nb_heads = 1, causal = False, attention_dropout = 0.0
+    ):
         super().__init__()
 
         def randw(*d):
-            return nn.Parameter(torch.empty(*d).normal_(0, 1 / math.sqrt(d[-1])))
+            return nn.Parameter(torch.randn(*d) / math.sqrt(d[-1]))
+
+        self.causal = causal
+        self.attention_dropout = attention_dropout
 
         self.w_q = randw(nb_heads, dim_qk, dim_in)
         self.w_k = randw(nb_heads, dim_qk, dim_in)
         self.w_v = randw(nb_heads, dim_v, dim_in)
-        self.causal = causal
-        self.attention_dropout = attention_dropout
+        self.w_o = randw(dim_v * nb_heads, dim_in)
 
     def forward(self, x_q, x_kv = None):
         if x_kv is None: x_kv = x_q
+
         q = torch.einsum('ntc,hdc->nhtd', x_q, self.w_q)
         k = torch.einsum('ntc,hdc->nhtd', x_kv, self.w_k)
         v = torch.einsum('ntc,hdc->nhtd', x_kv, self.w_v)
+
         a = torch.einsum('nhtd,nhsd->nhts', q, k) / math.sqrt(q.size(3))
+
         if self.causal:
-            mask = torch.tril(q.new_ones(a.size(2), a.size(3)))[None, None, :, :] == 0
+            mask = torch.arange(a.size(2), device = q.device)[None, None, :, None] \
+                   < torch.arange(a.size(3), device = q.device)[None, None, None, :]
             a = a.masked_fill(mask, float('-inf'))
+
         a = a.softmax(dim = 3)
         a = F.dropout(a, self.attention_dropout, self.training)
-        y = torch.einsum('nhts,nhsd->nhtd', a, v)
-        return y.permute(0, 2, 1, 3).flatten(2) # nhtd -> nt(hd)
+        y = torch.einsum('nhts,nhsd->nthd', a, v).flatten(2)
+
+        y = y @ self.w_o
+
+        return y
 
 ##############################
 
@@ -94,11 +108,11 @@ class MyGPT(nn.Module):
                     nn.LayerNorm(dim_model),
                     QKVAttention(
                         dim_in = dim_model,
-                        dim_qk = dim_keys, dim_v = dim_model // nb_heads,
+                        dim_qk = dim_keys,
+                        dim_v = dim_model // nb_heads,
                         nb_heads = nb_heads,
                         causal = True, attention_dropout = dropout
                     ),
-                    nn.Linear(in_features = dim_model, out_features = dim_model),
                 ),
                 Residual(
                     nn.LayerNorm(dim_model),
@@ -114,20 +128,23 @@ class MyGPT(nn.Module):
         self.readout = nn.Linear(in_features = dim_model, out_features = vocabulary_size)
 
     def forward(self, x):
+        x = F.pad(x, (1, 0))
         x = self.embedding(x)
         x = self.trunk(x)
         x = self.readout(x)
-        return x
+        return x[:, :-1]
 
 ######################################################################
 
 if __name__ == '__main__':
+    print('Basic check.')
+
     vocabulary_size = 10
     x = torch.randint(vocabulary_size, (25, 100))
 
     model = MyGPT(
         vocabulary_size = vocabulary_size,
-        dim_model = 16, dim_keys = 50, dim_hidden = 100,
+        dim_model = 18, dim_keys = 50, dim_hidden = 100,
         nb_heads = 2, nb_blocks = 3,
         dropout = 0.1
     )