X-Git-Url: https://fleuret.org/cgi-bin/gitweb/gitweb.cgi?a=blobdiff_plain;f=bash-selector.sh;h=9cae9a212a086b7d8786172ccc1b9dfed6c8cf3e;hb=089bd5db84375cdc0223df056aea8a4f63bbbf79;hp=38991b13047c79be9ec624fa908d99574b22feec;hpb=9ab77834b683d83a47b3f7327138ed14e3ab35cf;p=selector.git

diff --git a/bash-selector.sh b/bash-selector.sh
index 38991b1..9cae9a2 100755
--- a/bash-selector.sh
+++ b/bash-selector.sh
@@ -47,42 +47,51 @@ function selector-history () {
 # Selector-based directory history
 ######################################################################
 
-# The file where we will keep track of the directories
+# The file where we will keep track of the directories and how many
+# lines to keep in there
 
 export SELECTOR_CD_HISTORY
 
 [[ "${SELECTOR_CD_HISTORY}" ]] || SELECTOR_CD_HISTORY=${HOME}/.selector-cd-history
 
+export SELECTOR_CD_HISTORY_SIZE
+
+[[ "${SELECTOR_CD_HISTORY_SIZE}" ]] || SELECTOR_CD_HISTORY_SIZE=1000
+
 # The function to use in place of the standard "cd"
 
 function selector-cd () {
+    umask 077
+
     if [[ -z "$1" ]]; then
         cd
     else
         cd "$@"
     fi
 
-    if [[ -f ${SELECTOR_CD_HISTORY} ]]; then
+    if [[ -f "${SELECTOR_CD_HISTORY}" ]]; then
         TMP=$(mktemp /tmp/selector-cd.XXXXXX)
-        tail -999 < ${SELECTOR_CD_HISTORY} > ${TMP}
-        cat ${TMP} > ${SELECTOR_CD_HISTORY}
-        rm -f ${TMP}
+        tail -$((SELECTOR_CD_HISTORY_SIZE-1)) < "${SELECTOR_CD_HISTORY}" > "${TMP}"
+        cat "${TMP}" > "${SELECTOR_CD_HISTORY}"
+        rm -f "${TMP}"
     fi
 
-    echo $PWD | sed -e "s!^${HOME}!~!" >> ${SELECTOR_CD_HISTORY}
+    echo "${PWD}" | sed -e "s!^${HOME}!~!" >> "${SELECTOR_CD_HISTORY}"
 }
 
 function selector-cd-search () {
-    if [[ -f ${SELECTOR_CD_HISTORY} ]]; then
+    umask 077
+
+    if [[ -f "${SELECTOR_CD_HISTORY}" ]]; then
         PATH_TEMP=$(mktemp /tmp/selector-cd-path.XXXXXX)
-        selector -j -y -u -t "cd" -l 1000 -d -i -c 7,2,0,3 -o ${PATH_TEMP} -q ${SELECTOR_CD_HISTORY}
-        NEW_PATH="$(cat ${PATH_TEMP} | sed -e 's!~!'${HOME}'!')"
+        selector -j -y -u -t "cd" -l "${SELECTOR_CD_HISTORY_SIZE}" -d -i -c 7,2,0,3 -o "${PATH_TEMP}" -q "${SELECTOR_CD_HISTORY}"
+        NEW_PATH="$(cat "${PATH_TEMP}" | sed -e 's!~!'${HOME}'!')"
         if [[ -d "${NEW_PATH}" ]]; then
-            selector-cd "$(cat ${PATH_TEMP} | sed -e 's!^~!'${HOME}'!')"
+            selector-cd "$(cat "${PATH_TEMP}" | sed -e 's!^~!'${HOME}'!')"
         fi
-        \rm ${PATH_TEMP}
+        \rm "${PATH_TEMP}"
     else
-        echo "No cd history file ${SELECTOR_CD_HISTORY}." >&2
+        echo "No cd history file '${SELECTOR_CD_HISTORY}'." >&2
     fi
 }
 
@@ -92,8 +101,8 @@ alias cd=selector-cd
 # The key-bindings themselves
 ######################################################################
 
-    # M-t appends the selected history line and the end of the current
-    # one bind '"\C-[t":"\C-a\C-kselector-history\C-m\C-a\C-y\C-e"'
+# M-t appends the selected history line and the end of the current
+# one bind '"\C-[t":"\C-a\C-kselector-history\C-m\C-a\C-y\C-e"'
 
 if [[ "$1" ]]; then